Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rust mini version to 1.65. #30

Merged
merged 2 commits into from Nov 4, 2022
Merged

Upgrade rust mini version to 1.65. #30

merged 2 commits into from Nov 4, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Nov 4, 2022

Replace helper::try_option! with let-else feature in rust 1.65.

@jmjoy jmjoy added the enhancement New feature or request label Nov 4, 2022
@jmjoy jmjoy added this to the 0.2.0 milestone Nov 4, 2022
@jmjoy jmjoy marked this pull request as ready for review November 4, 2022 05:43
@jmjoy jmjoy requested a review from heyanlong November 4, 2022 05:44
heyanlong
heyanlong approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@heyanlong heyanlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyanlong heyanlong merged commit d3afbd4 into apache:master Nov 4, 2022
@jmjoy jmjoy deleted the mini branch November 4, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyanlong heyanlong heyanlong approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
2 participants
@jmjoy @heyanlong