Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #372: AppVeyor: Builds are failing but still show up as successful #373

Merged
merged 1 commit into from Apr 6, 2020
Merged

Fix #372: AppVeyor: Builds are failing but still show up as successful #373

merged 1 commit into from Apr 6, 2020

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Apr 6, 2020

We have to explicitly catch eventual batch errors, and rethrow.

@cmb69
Fix php-amqp#372: AppVeyor: Builds are failing but still show up as s…
05d2319 
…uccessful

We have to explicitly catch eventual batch errors, and rethrow.
@lstrojny lstrojny merged commit f848ece into php-amqp:master Apr 6, 2020
@lstrojny
Copy link
Collaborator

lstrojny commented Apr 6, 2020

Confirmed, it’s now failing nicely. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmb69 @lstrojny