Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take care of PDO false and DSN tailing semicolons. #22

Merged
merged 3 commits into from Oct 19, 2022
Merged

Take care of PDO false and DSN tailing semicolons. #22

merged 3 commits into from Oct 19, 2022

Conversation

phanalpha
Copy link
Contributor

No description provided.

@wu-sheng wu-sheng added the enhancement New feature or request label Oct 18, 2022
@wu-sheng wu-sheng added this to the 0.2.0 milestone Oct 18, 2022
@jmjoy
Copy link
Member

jmjoy commented Oct 18, 2022

Please format.

@heyanlong
Copy link
Member

@phanalpha You need to run cargo fmt --all -- --check to fix format problem, the problem report from https://github.com/apache/skywalking-php/actions/runs/3268126418/jobs/5377222949

@heyanlong
Copy link
Member

Also, could you commit your unit test?

@wu-sheng wu-sheng merged commit 05a34e1 into apache:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyanlong heyanlong heyanlong approved these changes

@jmjoy jmjoy jmjoy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
4 participants
@phanalpha @jmjoy @heyanlong @wu-sheng