[DI] Skip hot_path tag for deprecated services as their class might also be #25037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 19, 2017
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24959 |
| License | MIT |
| Doc PR | - |
ogizanagi
reviewed
Nov 19, 2017
| } | ||
| if ($value instanceof Reference && ContainerBuilder::IGNORE_ON_UNINITIALIZED_REFERENCE !== $value->getInvalidBehavior() && $this->container->has($id = (string) $value)) { | ||
| $definition = $this->container->findDefinition($id); | ||
| if (!$definition->hasTag($this->tagName)) { | ||
| if (!$definition->hasTag($this->tagName) && !$value->isDeprecated()) { |
There was a problem hiding this comment.
- !$value->isDeprecated()
+ !$definition->isDeprecated()?
But I'm still getting the deprecation with the mentioned reproducer and these changes :/
There was a problem hiding this comment.
should be good now
nicolas-grekas
force-pushed
the
di-skip-deprec
branch
3 times, most recently
from
1c90d1b
to
6f134b5
Compare
nicolas-grekas
force-pushed
the
di-skip-deprec
branch
from
6f134b5
to
1775bba
Compare
ogizanagi
approved these changes
Nov 20, 2017
fabpot
approved these changes
Nov 20, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 20, 2017
…ass might also be (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Skip hot_path tag for deprecated services as their class might also be | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24959 | License | MIT | Doc PR | - Commits ------- 1775bba [DI] Skip hot_path tag for deprecated services as their class might also be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.