[PropertyAccess] Fixed compatibility with preg_match in PHP 7.2 #22707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case covering this? |
|
Can we ensure there are no more place incompatible with this check? Failing property access was only an example, but the issue itself is more broad |
|
Before committing this, we should raise the concern on php-internals. Comments on php-src PRs are kinda ignored. This BC break should be challenged. |
|
CLosing as this should be resolved soon in php-src master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for compatibility with PCRE change in PHP 7.2.
preg_*will returnnullinstead of empty string for unmatched patterns.Broken in php/php-src#1303.