[Validator] Fixed the @Valid(groups={"group"}) against null exception case #25297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Validator
Bug
Status: Reviewed
and removed
Status: Needs Review
labels
javiereguiluz
approved these changes
Dec 4, 2017
|
Thank you @vudaltsov. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 4, 2017
…l exception case (vudaltsov) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Fixed the @Valid(groups={"group"}) against null exception case | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When `@Valid(groups={"group"})` has non-empty groups and the value is `null`, validator throws `Cannot validate values of type "NULL" automatically. Please provide a constraint.` at `RecursiveContextualValidator:164`. I don't really understand, why everything is okay for `@Valid()` without groups, but hope that my fix is correct anyway. Commits ------- 56f24d0 Fixed the null value exception case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
@Valid(groups={"group"})has non-empty groups and the value isnull, validator throwsCannot validate values of type "NULL" automatically. Please provide a constraint.atRecursiveContextualValidator:164.I don't really understand, why everything is okay for
@Valid()without groups, but hope that my fix is correct anyway.