[Security] Adding a GuardAuthenticatorHandler alias #25274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the file loader can't load the file anymore, could you please check why ? |
|
@Simperfit yea, I borked it :). Let's try that again |
|
Yea, it could be considered a bug fix: it really should be usable by the end-user. When the service became private in 4.0, that made it not easily usable. So, I think 3.4 makes sense (we could do 3.3... but I don't want to make a policy of back-porting all aliases to 3.3: we just need to make sure they exist on 3.4 so people can upgrade) |
fabpot
approved these changes
Dec 4, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Dec 4, 2017
…rryan) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #25274). Discussion ---------- [Security] Adding a GuardAuthenticatorHandler alias | Q | A | ------------- | --- | Branch? | master | Bug fix? | kinda | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | This feature is not currently documented The `security.authentication.guard_handler` service *is* actually meant to be available for users to use. Specifically, the `authenticateUserAndHandleSuccess()` method is useful to auto-login the user after, for example, registration, but maintain all the behavior of a normal login (success behavior, trigger the login event). So, it should have an autowiring alias. Commits ------- 844c402 [Security] Adding a GuardAuthenticatorHandler alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
security.authentication.guard_handlerservice is actually meant to be available for users to use. Specifically, theauthenticateUserAndHandleSuccess()method is useful to auto-login the user after, for example, registration, but maintain all the behavior of a normal login (success behavior, trigger the login event).So, it should have an autowiring alias.