This repository has been archived by the owner on May 1, 2020. It is now read-only.
LB-123: Setup Docker for MessyBrainz #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a docker-compose.yml, a Dockerfile and change some stuff in manage.py so that db is set up inside docker
Also remove an unused import which was causing tests to fail and add pytest to requirements
mayhem
approved these changes
May 29, 2017
|
I have the LB-160 patch ready to send as soon as this gets merged. |
Not needed anymore
alastair
approved these changes
May 31, 2017
| @@ -0,0 +1,34 @@ | |||
| FROM python:2.7.12 | |||
There was a problem hiding this comment.
I guess the idea is that we switch this to python3 once this PR is merged?
README.md
Outdated
| Everything should be good to go now. You should be able to access the webserver at `http://localhost:8080`. | ||
|
|
||
| Also, in order to run the tests, just use the command: `./test.sh`. | ||
|
|
||
| ### The Usual Way | ||
|
|
||
| Full installation instructions are available in [INSTALL.md](https://github.com/metabrainz/messybrainz-server/blob/master/INSTALL.md) file. |
There was a problem hiding this comment.
Do we need to have normal installation instructions? I'm happy to force everyone to use Docker
There was a problem hiding this comment.
Not really, I'll remove it.
| @@ -0,0 +1,130 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
We're now sharing these scripts among multiple projects. I wonder if it's a good idea that we make a separate project for them and git submodule them in for use by each project. Then our test.sh can just import this file and set a few variables.
Docker is the only supported install method now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of the stuff taken from LB. Had to fix some tests as well.