⚓ T150419 Allow users to restrict who can send them notifications

Subject	Repo	Branch	Lines +/-
More clear label for the textarea	mediawiki/extensions/Echo	master	+1 -1
Enable Echo per-user blacklist on meta	operations/mediawiki-config	master	+5 -0
Improve UI for blacklist preference	mediawiki/extensions/Echo	master	+1 -1
Fix user talk exception for blacklist	mediawiki/extensions/Echo	master	+13 -1
Implement per-user notification blacklists	mediawiki/extensions/Echo	master	+144 -43
Enable $wgEchoPerUserBlacklist in beta labs	operations/mediawiki-config	master	+4 -0
[experimental] Implement per-user notification blacklist with preference	mediawiki/extensions/Echo	master	+40 -4

Status	Assigned	Task
Resolved	matmarex	T192147 Regression: Changes to email blacklist or muted users do not activate Save button in Preferences
Resolved	dbarratt	T173973 Preferences/Notification, Save button stays disable when editing Block list
Resolved	None	T164542 Epic: ⚡️ General user mute/block feature
Resolved	• jmatazzoni	T150419 Allow users to restrict who can send them notifications
Resolved	dbarratt	T166626 Update message copy for Mute feature
Resolved	Catrope	T166836 Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS
Duplicate	None	T175081 Update Mute message link to include Special:MyLanguage
Resolved	• Mattflaschen-WMF	T166627 Internal error when you attempt to email a user you've blocked from Notifications
Resolved	• TBolliger	T166835 Audit all notification types to see if any more should be exceptions
Resolved	• TBolliger	T168489 Evaluate and decide if we need to capture any usage data for post-release analysis of Mute feature
Resolved	None	T169384 Blacklist UsersMultiselectWidget UI needs improvements
Resolved	• TBolliger	T169606 Document how to restrict notifications received
Resolved	dbarratt	T173475 Echo Notification Mute (Block List) can be bypassed by changing username
Resolved	dbarratt	T177437 Update Echo and Run Maintenance Script
Resolved	dbarratt	T173838 Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled
Resolved	Johan	T168902 Ping Johan and Translators mailing list about Echo Notifications blacklist strings
Open	None	T174485 UsersMultiselectWidget should throw error if unselected text is present onSubmit
Resolved	Mooeypoo	T188886 TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused

• jmatazzoni closed subtask T166627: Internal error when you attempt to email a user you've blocked from Notifications as Resolved.Jun 15 2017, 11:25 PM

Trizek-WMF changed the status of subtask T166626: Update message copy for Mute feature from Stalled to Open.Jun 16 2017, 8:51 AM

• TBolliger created subtask T168489: Evaluate and decide if we need to capture any usage data for post-release analysis of Mute feature.Jun 21 2017, 12:35 AM

Trizek-WMF moved this task from In current Collaboration Newsletter draft to Announced in Collaboration Newsletter on the User-notice-collaboration board.Jun 23 2017, 8:52 AM

RandomDSdevel awarded a token.Jun 23 2017, 9:46 PM

• TBolliger created subtask T168902: Ping Johan and Translators mailing list about Echo Notifications blacklist strings.Jun 26 2017, 7:05 PM

Change 354695 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Improve UI for blacklist preference

https://gerrit.wikimedia.org/r/354695

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 30 2017, 3:00 PM

This is now ready, except that @Mattflaschen-WMF points out there's something that's not implemented yet or not quite right yet around exempting user talk pages.

In T150419#3395600, @Catrope wrote:

This is now ready, except that @Mattflaschen-WMF points out there's something that's not implemented yet or not quite right yet around exempting user talk pages.

Sorry, I was wrong.

It should be fine after rECHO813ab5b54e4b: Fix user talk exception for blacklist.

The following notification will not be received if they are initiated by a user who was blocked:

edit-thank

emailuser

ep-campus-add-notification

ep-course-talk-notification

ep-instructor-add-notification

ep-online-add-notification

ep-student-add-notification

flow-mention

flow-new-topic

flow-post-edited

flow-post-reply

flow-summary-edited

flow-description-edited

flow-thank

flow-topic-renamed

flow-topic-resolved

mention

page-linked

pagetriage-add-maintenance-tag

reverted

user-rights

The following notifications will be received even if they were initiated by a blocked user:

edit-user-talk

flowusertalk-description-edited

flowusertalk-new-topic

flowusertalk-post-edited

flowusertalk-post-reply

flowusertalk-summary-edited

flowusertalk-topic-renamed

flowusertalk-topic-resolved

flow-thank (if the action happened on the user talk page)

mention (if the action happened on user talk pages)

pagetriage-add-deletion-tag

pagetriage-mark-as-reviewed

reverted (if reverts happened on the user talk page)

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Jul 1 2017, 1:30 AM

@TBolliger Per the above, Elena thinks this is ready to go. If you agree, the earliest this could be turned on on a production wiki is after our latest fixes for it have rolled out, which will be on July 12th or 13th depending on the wiki (normally it'd be a week earlier, but next week's deployment will be skipped because of the 4th of July holiday). Let us know what you want to do and when. The code is already on the beta labs wikis for testing, if you want to take a look.

• TBolliger added a subtask: T169384: Blacklist UsersMultiselectWidget UI needs improvements.Jul 3 2017, 3:03 PM

Thanks, @Catrope and @Etonkovidova !

Can we enable this on meta on the 12th/13th? There are a few minor sub-tasks I'd like to have @dbarratt investigate before a wider release.

@Catrope, @TBolliger - the functionality is working fine, however, there are still outstanding issues: T169384: Blacklist UsersMultiselectWidget UI needs improvements and T166626: Update message copy for Mute feature.

@TBolliger Just a question: Restricting notifications from anon users - has it ever been discussed?

Change 363049 had a related patch set uploaded (by Catrope; owner: Catrope):
[operations/mediawiki-config@master] Enable Echo per-user blacklist on meta

https://gerrit.wikimedia.org/r/363049

In T150419#3401314, @TBolliger wrote:

Thanks, @Catrope and @Etonkovidova !

Can we enable this on meta on the 12th/13th? There are a few minor sub-tasks I'd like to have @dbarratt investigate before a wider release.

I have created a config patch for this (see above) and scheduled it for deployment during the evening SWAT on Wednesday (at 23:00 UTC / 4pm PDT).

In T150419#3402273, @Etonkovidova wrote:

@TBolliger Just a question: Restricting notifications from anon users - has it ever be discussed?

@Etonkovidova — Great idea! and yes. This would fall under a different project we're considering (no Phab ticket yet): https://meta.wikimedia.org/wiki/Community_health_initiative/User_and_User_talk_page_protection_tools

It would essentially allow users to wall off entire groups of users, as opposed to a blacklist.

This idea is still brewing. How our users react to this blacklist will certainly inform our decisions.

In T150419#3402331, @Catrope wrote:

In T150419#3401314, @TBolliger wrote:

Thanks, @Catrope and @Etonkovidova !

Can we enable this on meta on the 12th/13th? There are a few minor sub-tasks I'd like to have @dbarratt investigate before a wider release.

I have created a config patch for this (see above) and scheduled it for deployment during the evening SWAT on Wednesday (at 23:00 UTC / 4pm PDT).

Please document first! T169606: Document how to restrict notifications received

Trizek-WMF moved this task from Announced in Collaboration Newsletter to Announce in next Collaboration Newsletter on the User-notice-collaboration board.Jul 4 2017, 9:09 AM

JJMC89 added a subscriber: Cameron11598.Jul 8 2017, 3:18 AM

I've checked on Meta and I haven't seen anything there. Normal?

Roan and I agreed to pull it from Wednesday's release.

Sorry for not communicating that earlier. Some annoying bugs in the feature were fixed this week, and we probably want to wait for the next train to roll out next week with those fixes before we enable this on a real wiki.

• jmatazzoni closed this task as Resolved.Jul 14 2017, 12:54 AM

• jmatazzoni claimed this task.

Liuxinyu970226 unsubscribed.Jul 14 2017, 12:58 AM

Trizek-WMF moved this task from Announce in next Collaboration Newsletter to In current Collaboration Newsletter draft on the User-notice-collaboration board.Jul 18 2017, 1:04 PM

Etonkovidova closed subtask T169384: Blacklist UsersMultiselectWidget UI needs improvements as Resolved.Jul 18 2017, 7:37 PM

Trizek-WMF closed subtask T169606: Document how to restrict notifications received as Resolved.Jul 19 2017, 8:11 AM

In T150419#3436307, @Catrope wrote:

Sorry for not communicating that earlier. Some annoying bugs in the feature were fixed this week, and we probably want to wait for the next train to roll out next week with those fixes before we enable this on a real wiki.

We are next week. What's new?

@Catrope — I just tested the UI and the mute functionality on beta, looks good to me. I say we release it on Meta with the next release.

In T150419#3457353, @TBolliger wrote:

@Catrope — I just tested the UI and the mute functionality on beta, looks good to me. I say we release it on Meta with the next release.

Alright, scheduled for Wednesday at 4pm Pacific.

Announced in Tech/News and the Collaboration team newsletter.

• TBolliger changed the status of subtask T168902: Ping Johan and Translators mailing list about Echo Notifications blacklist strings from Open to Stalled.Jul 24 2017, 8:52 PM

• TBolliger closed subtask T166836: Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS as Resolved.Jul 24 2017, 9:14 PM

• TBolliger changed the status of subtask T167902: Build a unified, cross-wiki Mute feature for multiple types of on-wiki and email communication from Open to Stalled.Jul 25 2017, 7:51 PM

Change 363049 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable Echo per-user blacklist on meta

https://gerrit.wikimedia.org/r/363049

Mentioned in SAL (#wikimedia-operations) [2017-07-26T23:30:14Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:363049|Enable Echo per-user blacklist on meta]] T150419 (duration: 00m 49s)

Feature is now live on Meta.

• TBolliger closed subtask T168489: Evaluate and decide if we need to capture any usage data for post-release analysis of Mute feature as Resolved.Jul 26 2017, 11:39 PM

• TBolliger mentioned this in T138166: Allow users to restrict who can send them direct emails via Special:EmailUser.Jul 28 2017, 5:54 PM

Trizek-WMF moved this task from In current Collaboration Newsletter draft to Announced in Collaboration Newsletter on the User-notice-collaboration board.Aug 4 2017, 8:52 AM

• TBolliger moved this task from Product/Tech backlog to Cards ready for development on the Anti-Harassment board.Aug 16 2017, 9:34 PM

dbarratt mentioned this in T173475: Echo Notification Mute (Block List) can be bypassed by changing username.Aug 16 2017, 11:54 PM

dbarratt closed subtask T166626: Update message copy for Mute feature as Resolved.Aug 17 2017, 5:51 PM

• TBolliger moved this task from Cards ready for development to AHT Sprint 3 on the Anti-Harassment board.Aug 17 2017, 7:01 PM

• TBolliger edited projects, added Anti-Harassment (AHT Sprint 3); removed Anti-Harassment.

• TBolliger moved this task from Ready to Done on the Anti-Harassment (AHT Sprint 3) board.Aug 17 2017, 7:10 PM

• TBolliger added a subtask: T173475: Echo Notification Mute (Block List) can be bypassed by changing username.Aug 18 2017, 4:36 PM

dbarratt mentioned this in T171624: Investigate making Mute cross-wiki.Aug 21 2017, 4:17 PM

• TBolliger mentioned this in T173838: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled.Aug 22 2017, 2:57 PM

• TBolliger created subtask T173838: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled.

• TBolliger changed the status of subtask T173838: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled from Open to Stalled.Aug 22 2017, 3:03 PM

• TBolliger changed the status of subtask T168902: Ping Johan and Translators mailing list about Echo Notifications blacklist strings from Stalled to Open.

• TBolliger changed the status of subtask T167902: Build a unified, cross-wiki Mute feature for multiple types of on-wiki and email communication from Stalled to Open.Aug 22 2017, 3:22 PM

David_Hedlund unsubscribed.Aug 22 2017, 3:23 PM

dbarratt changed the status of subtask T173475: Echo Notification Mute (Block List) can be bypassed by changing username from Stalled to Open.Aug 22 2017, 6:13 PM

I don't know if you're aware of that, but I could see the title of T173475 and the title and initial description of T173854 in my email. (Note I'm a watcher of Anti-Harassment.) This shouldn't happen if they were created properly, which I can't check. (Besides, the first one is so obvious, I wouldn't hide it at all, while I remember reading about the second one in public areas of WMF infrastructures.)

In T150419#3542351, @MGChecker wrote:

I don't know if you're aware of that, but I could see the title of T173475 and the title and initial description of T173854 in my email. (Note I'm a watcher of Anti-Harassment.) This shouldn't happen if they were created properly, which I can't check. (Besides, the first one is so obvious, I wouldn't hide it at all, while I remember reading about the second one in public areas of WMF infrastructures.)

I created {T173854} as a sub-task of a security issue. It's baffling that it doesn't automatically (or at minimum provide the option during creation) mark subtasks of security issues as security issues.

But now I've learned and will avoid it in the future.

• TBolliger removed a subtask: T167902: Build a unified, cross-wiki Mute feature for multiple types of on-wiki and email communication.Aug 23 2017, 6:58 PM

• TBolliger mentioned this in T167902: Build a unified, cross-wiki Mute feature for multiple types of on-wiki and email communication.Aug 23 2017, 7:03 PM

• TBolliger closed subtask T168902: Ping Johan and Translators mailing list about Echo Notifications blacklist strings as Resolved.Aug 24 2017, 4:17 PM

• TBolliger closed subtask T166835: Audit all notification types to see if any more should be exceptions as Resolved.Aug 25 2017, 11:58 PM

dbarratt closed subtask T173838: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled as Resolved.Aug 28 2017, 6:25 PM

• TBolliger added a subtask: T173973: Preferences/Notification, Save button stays disable when editing Block list .Aug 29 2017, 7:21 PM

• TBolliger created subtask T174485: UsersMultiselectWidget should throw error if unselected text is present onSubmit.Aug 29 2017, 7:27 PM

dbarratt changed the status of subtask T173475: Echo Notification Mute (Block List) can be bypassed by changing username from Open to Stalled.Sep 1 2017, 5:06 PM

dbarratt closed subtask T173973: Preferences/Notification, Save button stays disable when editing Block list as Resolved.Sep 5 2017, 4:18 PM

In T150419#3542516, @TBolliger wrote:

I created {T173854} as a sub-task of a security issue. It's baffling that it doesn't automatically (or at minimum provide the option during creation) mark subtasks of security issues as security issues.

Can you file the "subtasks of security not created as security" problem as a Phabricator issue (our tracker, tagged Phabricator) if you didn't already?

• Mattflaschen-WMF unsubscribed.Sep 5 2017, 7:58 PM

In T150419#3581774, @Mattflaschen-WMF wrote:

In T150419#3542516, @TBolliger wrote:

I created {T173854} as a sub-task of a security issue. It's baffling that it doesn't automatically (or at minimum provide the option during creation) mark subtasks of security issues as security issues.

Can you file the "subtasks of security not created as security" problem as a Phabricator issue (our tracker, tagged Phabricator) if you didn't already?