[Console] Use proper line endings in BufferedOutput #21981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienfalque
force-pushed
the
buffered-output-newline
branch
from
800f199
to
a808bb8
Compare
julienfalque
force-pushed
the
buffered-output-newline
branch
from
a808bb8
to
33946e6
Compare
keradus
approved these changes
Mar 14, 2017
Nek-
approved these changes
Mar 14, 2017
|
Thank you @julienfalque. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2017
…nfalque) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Use proper line endings in BufferedOutput | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - `BufferOutput` should be consistent with `StreamOutput` when writing newlines. I faced an issue using this class in tests where the expected output was platform dependent (using `PHP_EOL` too). Commits ------- 33946e6 Use proper line endings
This was referenced Apr 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferOutputshould be consistent withStreamOutputwhen writing newlines.I faced an issue using this class in tests where the expected output was platform dependent (using
PHP_EOLtoo).