perf(router): don't create new serializer every time UrlTree.toString is called #15565
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Mar 28, 2017
packages/router/src/url_tree.ts
Outdated
| @@ -103,6 +103,7 @@ function containsSegmentGroupHelper( | |||
| * @stable | |||
| */ | |||
| export class UrlTree { | |||
| private serializer = new DefaultUrlSerializer(); | |||
There was a problem hiding this comment.
scope it to the file so that we don't have to create it for all new Tree ?
vicb
added
area: router
action: cleanup
DzmitryShylovich
force-pushed
the
gh/urltree-perf
branch
from
869fe8f to
51385ed
Compare
|
@vicb fixed |
DzmitryShylovich
force-pushed
the
gh/urltree-perf
branch
from
51385ed to
b442853
Compare
vicb
reviewed
Mar 28, 2017
packages/router/src/url_tree.ts
Outdated
| @@ -294,6 +294,8 @@ export class DefaultUrlSerializer implements UrlSerializer { | |||
| } | |||
| } | |||
|
|
|||
| const serializer = new DefaultUrlSerializer(); | |||
There was a problem hiding this comment.
move this up and change the name to DEFAULT_SERIALIZER pls
There was a problem hiding this comment.
Right, could you please only change the name then ?
DzmitryShylovich
force-pushed
the
gh/urltree-perf
branch
from
b442853 to
d310581
Compare
vicb
approved these changes
Mar 28, 2017
vicb
added
action: merge
DzmitryShylovich
force-pushed
the
gh/urltree-perf
branch
from
d310581 to
1e8db1d
Compare
vicb
pushed a commit
that referenced
this pull request
Mar 29, 2017
smurfy
pushed a commit
to smurfy/angular
that referenced
this pull request
Apr 7, 2017
smurfy
pushed a commit
to smurfy/angular
that referenced
this pull request
May 2, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultUrlSerializeris stateless so there's no need to create a new instance every time.