[DI] Throw an exception if Expression Language is not installed #25285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
changed the title
|
Are we really going to do this now on each place where optional dependency is used? I'm 👎 on that. There should be global solution and/or not doing this at all and just document what such php error usually means. |
Simperfit
reviewed
Dec 3, 2017
| @@ -155,6 +156,10 @@ private function getDefinitionId($id) | |||
| private function getExpressionLanguage() | |||
| { | |||
| if (null === $this->expressionLanguage) { | |||
| if (!class_exists('Symfony\Component\ExpressionLanguage\ExpressionLanguage')) { | |||
There was a problem hiding this comment.
why not :
if (!class_exists(ExpressionLanguage::class)) {
//body
}
There was a problem hiding this comment.
copy/pasting from the other check, that's it :)
There was a problem hiding this comment.
Yeah but I think it's better to use this since we already replaced some of the one we had in the symfony code base. Let's introduce something we don't need to re-modify in the futur :p.
nicolas-grekas
approved these changes
Dec 4, 2017
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 4, 2017
…alled (sroze) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Throw an exception if Expression Language is not installed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25277 | License | MIT | Doc PR | ø The [`PhpDumper` already has this check](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php#L1688-L1690) but it is missing here. Commits ------- 75b21e9 Throw an exception is expression language is not installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PhpDumperalready has this check but it is missing here.