Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Cache pool clear command requires at least 1 pool #22159

Closed
wants to merge 1 commit into from
Closed

[FrameworkBundle] Cache pool clear command requires at least 1 pool #22159

wants to merge 1 commit into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Mar 25, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets #22047
License MIT
Doc PR symfony/symfony-docs#...

The commands help description already states this should be required.

The cache:pool:clear command clears the given cache pools or cache pool clearers.
  
    bin/console cache:pool:clear <cache pool or clearer 1> [...<cache pool or clearer N>]

So this could also be qualified a bugfix.

@fabpot
Copy link
Member

fabpot commented Mar 25, 2017

Merging it as a bug fix.

@fabpot
Copy link
Member

fabpot commented Mar 25, 2017

Thank you @ro0NL.

fabpot added a commit that referenced this pull request Mar 25, 2017
…st 1 pool (ro0NL)

This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #22159).

Discussion
----------

[FrameworkBundle] Cache pool clear command requires at least 1 pool

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes/no
| Fixed tickets | #22047
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

The commands help description already states this should be required.

```
The cache:pool:clear command clears the given cache pools or cache pool clearers.

    bin/console cache:pool:clear <cache pool or clearer 1> [...<cache pool or clearer N>]
```

So this could also be qualified a bugfix.

Commits
-------

a61797f [FrameworkBundle] Cache pool clear command requires at least 1 pool
@ro0NL ro0NL closed this Mar 25, 2017
@ro0NL ro0NL deleted the console/cachepool branch March 25, 2017 16:03
@fabpot fabpot mentioned this pull request Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants