style attribute with expressions makes show directive invalid at the beginning #2178

Joylei · 2016-12-25T14:02:28Z

Help us to manage our issues by answering the following:

Describe your issue:

if there are expressions in style attribute, the show directive would not work at the beginning

    <child>
      <button onclick="{ toggle }">toggle</button>
      <p show="{ selected }" style="height:{ height };">should be hidden when inited</p>
      
      this.selected = false
      this.height = 'auto'
      this.toggle = ()=>{
        this.selected = !this.selected
      }
    </child>

Can you reproduce the issue?

http://jsbin.com/yokegejoca/edit?html,output

On which browser/OS does the issue appear?
macOS 10.12.2; Chrome 55
Which version of Riot does it affect?
3.0.5
How would you tag this issue?

GianlucaGuarini · 2017-01-09T17:48:49Z

I think it's related to #2158

rsbondi · 2017-01-09T17:58:34Z

I believe style=whatever is overriding the display: none set by show, maybe if this was handled in update it would solve both issues

Joylei · 2017-01-11T09:03:30Z

@rsbondi
agree.

rsbondi · 2017-01-20T18:08:42Z

#2178

* master: updated: fixed wrong text in the readme file updated: libraries sizes 3.4.0 added: support for style and class object attributes closes #2178 updated: simplified the special expressions updates updated: cleaning up the update method updated: dbmon frames rendering strategy closes #2080 closes #2103 fixed: make sure that the riot version gets exported as string updated: dev dependencies Enable syntax highlighting of tag files updated: small optimization avoiding the shouldUpdate check for the anonymous tags updated: dev dependencies Delete a duplicate line

rsbondi added the bug label Dec 25, 2016

rsbondi added the duplicate label Jan 20, 2017

GianlucaGuarini mentioned this issue Jan 21, 2017

Tags: "show" attribute interpolation, order of eval seems to matter #2230

Closed

6 tasks

GianlucaGuarini added a commit that referenced this issue Mar 26, 2017

closes #2178

c2ac93a

GianlucaGuarini added the fixed label Mar 26, 2017

GianlucaGuarini closed this as completed in 794fccf Mar 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

style attribute with expressions makes show directive invalid at the beginning #2178

style attribute with expressions makes show directive invalid at the beginning #2178

Joylei commented Dec 25, 2016

GianlucaGuarini commented Jan 9, 2017

rsbondi commented Jan 9, 2017

Joylei commented Jan 11, 2017

rsbondi commented Jan 20, 2017

style attribute with expressions makes show directive invalid at the beginning #2178

style attribute with expressions makes show directive invalid at the beginning #2178

Comments

Joylei commented Dec 25, 2016

Help us to manage our issues by answering the following:

GianlucaGuarini commented Jan 9, 2017

rsbondi commented Jan 9, 2017

Joylei commented Jan 11, 2017

rsbondi commented Jan 20, 2017