[Console] Revised exception rendering #22188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Mar 27, 2017
|
Done. Test on 2.7 |
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2017
This PR was squashed before being merged into the 2.7 branch (closes #22188). Discussion ---------- [Console] Revised exception rendering | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Continuation of #22142, as escaping can break too i just realized. Before  After  cc @chalasr Commits ------- 17f1f07 [Console] Revised exception rendering
Merged
fabpot
added a commit
that referenced
this pull request
Apr 4, 2017
This PR was squashed before being merged into the 3.2 branch (closes #22270). Discussion ---------- [Console] Fix render exception test | Q | A | ------------- | --- | Branch? | 3.2 and up | Bug fix? | yes (regression from #22188 in master) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22217 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> As pointed out by @chalasr tests are mysteriously broken.. not sure what i missed but this is apparently needed now.. cc @fabpot Commits ------- 6b71722 [Console] Fix render exception test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #22142, as escaping can break too i just realized.
Before
After
cc @chalasr