[Serializer] [XML] Ignore Process Instruction #22044
Conversation
| '<item><title>title1</title></item><?item ignore-title ?><item><title>title2</title></item>'. | ||
| '<Barry><FooBar id="1"><Baz>Ed</Baz></FooBar></Barry></baz>'. | ||
| '<qux>1</qux>'. | ||
| '</response><?instrtuction <value> ?>'."\n"; |
There was a problem hiding this comment.
- You should use nowdoc here.
- instrtuction => instruction
There was a problem hiding this comment.
@greg0ire oups, fixed, thanks ^^
There was a problem hiding this comment.
No problem, but what about the nowdoc?
There was a problem hiding this comment.
@greg0ire can you tell me more about this ? really don't know that: What change do you expect ?
| '<item><title>title1</title></item><?item ignore-title ?><item><title>title2</title></item>'. | ||
| '<Barry><FooBar id="1"><Baz>Ed</Baz></FooBar></Barry></baz>'. | ||
| '<qux>1</qux>'. | ||
| '</response><?instruction <value> ?>'."\n"; |
There was a problem hiding this comment.
Here is how it could look in case you don't know nowdoc:
<?php
return <<<'XML'
<?xml version="1.0"?>
<?xml-stylesheet type="text/xsl" href="/xsl/xmlverbatimwrapper.xsl"?>
<?display table-view?>
<?sort alpha-ascending?>
<response>
<foo>foo</foo>
<?textinfo whitespace is allowed ?>
<bar>a</bar><bar>b</bar>
<baz><key>val</key><key2>val</key2><item key="A B">bar</item>
<item><title>title1</title></item><?item ignore-title ?><item><title>title2</title></item>
<Barry><FooBar id="1"><Baz>Ed</Baz></FooBar></Barry></baz>
<qux>1</qux>
</response><?instruction <value> ?>
XML;- no quotes
- no linebreaks
- no concatenation
- syntactic coloration
- but it kind of breaks the indention
There was a problem hiding this comment.
ah , I see ^^! I just do like this to be conform to the existing example in the file. If contributors approves, I will do it.
There was a problem hiding this comment.
I also prefer the nowdoc syntax as suggested by @greg0ire. As an interesting side effect, it allows PHPStorm to highlight embedded document.
| @@ -465,6 +473,23 @@ public function testDecodeEmptyXml() | |||
| $this->encoder->decode(' ', 'xml'); | |||
| } | |||
|
|
|||
| protected function getXmlPISource() | |||
There was a problem hiding this comment.
You probably can make this private, or at least final
There was a problem hiding this comment.
@greg0ire same response. just want to be conform to the existing code. But in fact, you're right ^^
There was a problem hiding this comment.
Oh ok great 👍 I hope they won't make you change all other examples for the sake of consistency :P
There was a problem hiding this comment.
I think you can use a private method for a new method.
|
ping @nicolas-grekas . WDYT ? ^^ |
|
👍 (when the small comments will be fixed). |
|
@dunglas , here it is :-) |
| @@ -465,6 +473,41 @@ public function testDecodeEmptyXml() | |||
| $this->encoder->decode(' ', 'xml'); | |||
| } | |||
|
|
|||
| private function getXmlPISource() | |||
There was a problem hiding this comment.
I would even get rid of this function and put the doc in testDecodeXMLWithProcessInstruction.
|
Thank you @jordscream. |
This PR was merged into the 2.7 branch. Discussion ---------- [Serializer] [XML] Ignore Process Instruction | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22005 | License | MIT | Doc PR | N/A This Pull request ignores Process instruction data in XML for decoding the data. Commits ------- 0c741f5 [Serializer] [XML] Ignore Process Instruction
…scream) This PR was merged into the 2.7 branch. Discussion ---------- [Serializer] [XML] Ignore Process Instruction | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#22005 | License | MIT | Doc PR | N/A This Pull request ignores Process instruction data in XML for decoding the data. Commits ------- 0c741f5 [Serializer] [XML] Ignore Process Instruction
This Pull request ignores Process instruction data in XML for decoding the data.