Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page #22123

Merged
merged 1 commit into from Mar 23, 2017
Merged

[WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page #22123

merged 1 commit into from Mar 23, 2017

Conversation

e-moe
Copy link
Contributor

@e-moe e-moe commented Mar 23, 2017

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22107
License MIT
Doc PR none

javiereguiluz
javiereguiluz reviewed Mar 23, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on my TODO list, so thanks for contributing it.

However, I'd like to propose some changes:

  1. What if we also add the nowrap to message.domain (it's ugly to see messages split into several lines).

  2. I'm worried about applying nowrap to message.translation because the translation can be incredible long. That's the usual case because apps use keys, so message.id is short and message.translation is long.

@e-moe
Copy link
Contributor Author

e-moe commented Mar 23, 2017

@javiereguiluz , sorry for stealing items from your todo list :)

I do agree with length of message.translation and will update this PR. As for message.domain - currently it has additional styles like bold and small. I have doubts about visual appearance of this item with one more style applied

@javiereguiluz
Copy link
Member

Here is the before/after if we add nowrap to domain and id but not the message:

before

after

It looks better now, right? so maybe we should add the nowrap to the translation domain after all.

@e-moe
Copy link
Contributor Author

e-moe commented Mar 23, 2017

oh, sorry. got your point. thanks for you review! PR is updated

@javiereguiluz
Copy link
Member

Thanks for fixing this bug @e-moe.

@javiereguiluz javiereguiluz merged commit d980e70 into symfony:2.8 Mar 23, 2017
javiereguiluz added a commit that referenced this pull request Mar 23, 2017
@javiereguiluz
bug #22123 [WebProfilerBundle] Fix for CSS attribute at Profiler Tran…
f354a47 
…slation Page (e-moe)

This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22107
| License       | MIT
| Doc PR        | none

Commits
-------

d980e70 [WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page
@javiereguiluz javiereguiluz mentioned this pull request Mar 23, 2017
Closed
This was referenced Apr 5, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@e-moe @javiereguiluz @xabbuh @carsonbot