-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synology ftp #305
Comments
Just as a note. the function in ftp.php listDirectoryContents also needs to be changed.
|
@kristianedlund Hi, I'm not familiar with synology NAS. I'm assuming this is a windows ftp server, correct? |
@FrenkyNet No the NAS is running on a unix system and most of the answers comes out as correct unix answers. Such as the stat command when the file is found. However, it has an extra line when the file is not found. I have a local copy working with the synology server, and I am just working towards making it a unit tested version before submitting a pull request for it. |
@kristianedlund awesome, looking forward to the PR! Would maybe even make sense to extend the Ftp adapter rather than handling different cases in one. |
@FrenkyNet That is up to you. I can do either one I think. But from the whole issue I can see around windows based I think you might end up with a whole lot of FTP adapters. On the other hand it is not a bigger issue than it can be refactored later on. Just let me know which one you prefer and I will aim for that. |
Hi
I was testing flysystem with the FTP on a synology NAS. It turns out the response to the STAT command is a tad different than the default implementation when a file does not exist.
Instead of just returning two lines like standard ftp servers, it returns:
I am not sure how to approach this, or if it should be handled by flysystem. So far I hacked it by just changing the ftp function getMetadata to
I will be happy to make a pull request, but I am uncertain how to approach it the problem.
The text was updated successfully, but these errors were encountered: