Fix ambiguous pattern #24956
Merged
Fix ambiguous pattern #24956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Bug
Status: Reviewed
and removed
Status: Needs Review
labels
nicolas-grekas
approved these changes
Nov 15, 2017
|
@weltling could you please update the PR description and change the licence to MIT? |
|
@nicolas-grekas done, fine with MIT here, too. That's probably why the check was failing :) Thanks. |
|
@weltling for sure, all green now, thanks! |
xabbuh
approved these changes
Nov 15, 2017
stof
approved these changes
Nov 17, 2017
|
Thank you @weltling. |
stof
added a commit
that referenced
this pull request
Nov 17, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix ambiguous pattern [Validator][Constraints][UrlValidator] Fix domain name pattern. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `\pS` is a unicode character class, `\pS-\.` pretends to be a range which is not. This pattern fails with PCRE2. Thanks. Commits ------- 059f59a Fix ambiguous pattern
This was referenced Dec 4, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Validator][Constraints][UrlValidator] Fix domain name pattern.
\pSis a unicode character class,\pS-\.pretends to be a range which is not. This pattern fails with PCRE2.Thanks.