[FrameworkBundle] Dont create empty bundles directory by default #25033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Nov 19, 2017
| $bundlesDir = $targetArg.'/bundles/'; | ||
| $this->filesystem->mkdir($bundlesDir, 0777); |
There was a problem hiding this comment.
given symlink() creates the parent directory, and mkdir() handles parents recursively, we could drop this line.
fabpot
approved these changes
Nov 20, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Nov 20, 2017
…efault (ro0NL) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Dont create empty bundles directory by default | Q | A | ------------- | --- | Branch? | 3.4 / 4.1? | Bug fix? | yes? | New feature? | no | BC breaks? | no? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> we still run `assets:install` by default, which in bundle-less apps gives this annoying empty public/bundles dir and some useless cli output, all the time. This fixes it. Commits ------- f8e7478 [FrameworkBundle] Dont create empty bundles directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we still run
assets:installby default, which in bundle-less apps gives this annoying empty public/bundles dir and some useless cli output, all the time. This fixes it.