Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test. MSVC doesn't have definition of NAN #43

Merged
merged 1 commit into from Jun 30, 2014
Merged

Fix test. MSVC doesn't have definition of NAN #43

merged 1 commit into from Jun 30, 2014

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Jun 30, 2014

So use quiet_NaN, infinity

kazuho added a commit that referenced this pull request Jun 30, 2014
@kazuho
Merge pull request #43 from mattn/fix_test
5e71db9 
Fix test. MSVC doesn't have definition of NAN
@kazuho kazuho merged commit 5e71db9 into kazuho:master Jun 30, 2014
@kazuho
Copy link
Owner

kazuho commented Jun 30, 2014

Note: https://gist.github.com/mattn/bf1e56aa832c031e5df6 illustrates the problem. MSVC somehow succeeds in compiling the code, and C(double) never gets called.

EDIT. IMO the behavior of MSVC is conformant to the specification of C language (int (i); is equiv. to int i;) and there is no guarantee in compilers not conforming to C99 that NAN is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattn @kazuho