Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows #9

Merged
merged 1 commit into from Sep 16, 2014
Merged

Support windows #9

merged 1 commit into from Sep 16, 2014

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Sep 16, 2014

It's too short changes. But it support windows. :)

@ericchiang
Copy link
Owner

Thanks, though I know almost nothing about windows. Would you mind explaining a little bit about how this works?

@mattn
Copy link
Contributor Author

mattn commented Sep 16, 2014

Windows doesn't support ANSI color with escape sequence.

So used go-colorable to parse and colorize.

ericchiang added a commit that referenced this pull request Sep 16, 2014
@ericchiang ericchiang merged commit d0b9bf4 into ericchiang:master Sep 16, 2014
@ericchiang
Copy link
Owner

Awesome. Thanks a bunch!

@mattn
Copy link
Contributor Author

mattn commented Sep 16, 2014

Thanks!

Posted blog entry just now. http://mattn.kaoriya.net/software/20140916103411.htm (japanese)

@ericchiang
Copy link
Owner

There's a release for your change:

https://github.com/EricChiang/pup/releases/tag/0.1.2

@mattn mattn deleted the windows branch May 26, 2015 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants