This was an Outreachy-Round-11 project to improve the categorization of pictures in the Upload to Commons Android application.
Please report any issues with the Commons App for Android at https://github.com/commons-app/apps-android-commons
This was an Outreachy-Round-11 project to improve the categorization of pictures in the Upload to Commons Android application.
Please report any issues with the Commons App for Android at https://github.com/commons-app/apps-android-commons
Thanks for the update, @harisanker24 !
@maskaravivek Thanks for your feedback. I've made some changes accordingly.
Nice to see that you have submitted a proposal for the project. Your past work looks really interesting :)
Thanks @josephine_l ! I'll make the necessary changes.
Glad to see that you are working on your proposal. :) I especially like the detailed task breakdowns - it's great that you have suggested documenting the results of various API strategies, and mockups for each UI phase.
This issue is currently tracked at https://github.com/commons-app/apps-android-commons/issues/144 , please refer there instead (sorry, @Aklapper , we had to do some housekeeping in our GitHub issues).
This needs to be handled in the issue tracker of the app, which is https://github.com/commons-app/apps-android-commons/issues/254
Thanks for the suggestion. We do have plans to add more licenses to the app - the task is currently tracked at https://github.com/commons-app/apps-android-commons/issues/254 . Unfortunately I don't have the time currently to implement it, due to other commitments. However, I have outlined the steps needed for implementation on that GitHub thread, and it would make a good starter task for someone wanting to get involved with our codebase, so if any volunteers are interested in picking it up, that would be great. :) Alternatively, I could include it (along with adding explicit license selection, as the current license selection method is less than ideal) in my IEG renewal proposal at the start of next year.
Hi @Qgil , yes I completed this task during the Dec 2015 Outreachy round. :)
Thanks @josephine_l. I assume the merit is yours? :)
Closing this, if anyone disagrees please feel free to reopen.
Just to clarify, are you requesting this feature for the web-based Upload Wizard? Commons-App-Android-Upload is for the Commons Android app.
@Whatamidoing-WMF : Could you explain how this task is related to Commons-App-Android-Upload ?
Adding UploadWizard.
Thank you @josephine_l.
Excellent, happy to hear that!
@josephine_l, i did not see any wrong location template in files uploaded by this app over a long time. I would suggest to close the ticket.
@josephine_l, it is no big thing. Just wanted that you are aware of it. Other version number i did not check yet.
@Aschroet - Ah, I looked into the developer console history to refresh my memory and yes, there was a mixup before. About a year ago, I was new to the app and it was my first release, so I mistakenly titled the release after 1.3 as '1.31'. :) I was informed of the error and fixed it, but that was a while later, so some uploads must have gone through.
@josephine_l, i know that this is off-topic but could you please tell me why i find lots of older uploads with
{{Uploaded from Mobile|platform=Android|version=1.31}} , as for example: https://commons.wikimedia.org/wiki/File:Pepper_robot_programming_workshop.jpg. I am not aware of the history of development of the app but is there some inconsistent version numbering? I expected to find only new uploads after your last release by doing this search: https://commons.wikimedia.org/w/index.php?title=Special:Search&profile=advanced&profile=advanced&fulltext=Search&search=insource%3A%22version\%3D1.31%22+hastemplate%3AUploaded_from_Mobile&ns0=1&ns6=1&ns9=1&ns12=1&ns14=1&ns100=1&ns106=1.
I will have to release a hotfix for another bug anyway, so no harm putting this in v1.31 and seeing how it goes. Do let me know. :)
@josephine_l, for me this looks good. However, it was just a guess what i described. I did not reproduce this behavior on my phone. So it is up to you to decide if this fix is going productive.
@josephine_l , can it be that the (0,0) is the assumed user location? As i see in GPSExtractor.java the double values of currentLatitude and currentLongitude are not initialized, resulting in a "0.0" if they were not updated by MyLocationListener before the photo is uploaded. If the app is configured to use the user location the (0,0) appears in the upload.
(0,0) is a valid value for a location. However, it is very unlikely to have such a photo since it would be located somewhere in the Atlantic ocean on the west coast of Africa. In any case, for me it is unclear where the value is taken from because it is not in the photo.