update script sources to be even with the example file ... #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <script src="https://fb.me/react-{{site.react_version}}.js"></script> | ||
| <script src="https://fb.me/JSXTransformer-{{site.react_version}}.js"></script> | ||
| <script src="https://code.jquery.com/jquery-2.1.3.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/react/0.13.0/react.js"></script> |
There was a problem hiding this comment.
We should leave this with {{site.react_version}} in there. That ensures we don't need to update this page for every release.
There was a problem hiding this comment.
@zpao should be fixed with 4564e555b3b815f1ac8fcf9fd46eb61412b556aa ~
zpao
added
Component: Documentation & Website
and removed
GH Review: review-needed
labels
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Great. 1 more request - could you flatten these to a single commit? |
…ct-tutorial repo ... apply to japanese and korean translation (+2 squashed commit) Squashed commit: [4564e55] Ensures we don't need to update this page for every release. [b0d60f9] update script sources to be even with the example file in reactjs/react-tutorial repo
|
ping @zpao -- don't know if you had been notified that commits have been flatten as requested. |
|
Ah, nope. Github doesn't send notifications for commit changes. Looks great, thanks! |
zpao
added a commit
that referenced
this pull request
Jun 16, 2015
update script sources to be even with the example file ...
|
Cheers! You tested my git-via-sourcetree knowledge there, to squash commits to one ;) |
This was referenced Jan 12, 2022
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in reactjs/react-tutorial repo
cf. reactjs/react-tutorial#57